Cope with more "interesting" proxy configurations when accessing the UI #49118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A follow up to #49106, we don't actually need to specify the host, and in some more complex routing circumstances with WAFs and multiple layers of (not prefectly configured) proxies etc this can lead to a different hostname between what the UA sent and what makes it to the Airflwo API server. However we can simplify this, and just use the `path` property -- this will always be right (defaults to a sane value, but uses the correct value from the base URL config option.)
ashb
requested review from
ephraimbuddy,
pierrejeambrun,
rawwar and
vincbeck
as code owners
dstandish
approved these changes
Apr 11, 2025
vatsrahul1001
approved these changes
Apr 11, 2025
kaxil
approved these changes
Apr 11, 2025
2 tasks
dheerajturaga
added a commit
to dheerajturaga/airflow
that referenced
this pull request
Apr 14, 2025
Resolves apache#49229 Login with FabAuthManager fails when api.base_url is unset. Aligning with implementation with apache#49118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to #49106, we don't actually need to specify the host, and in some
more complex routing circumstances with WAFs and multiple layers of (not
prefectly configured) proxies etc this can lead to a different hostname
between what the UA sent and what makes it to the Airflwo API server.
However we can simplify this, and just use the
pathproperty -- this willalways be right (defaults to a sane value, but uses the correct value from the
base URL config option.)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.