feat: Explicitly propagate airflow logging level to OL client #49108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
reviewed
Apr 11, 2025
providers/openlineage/src/airflow/providers/openlineage/plugins/adapter.py
Show resolved
Hide resolved
kacpermuda
force-pushed
the
ol-explicit-forward-logging-level
branch
from
eabc42b to
817aa5b
Compare
kacpermuda
force-pushed
the
ol-explicit-forward-logging-level
branch
from
817aa5b to
c40ddd7
Compare
eladkal
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in Airflow logging settings in Airflow 3, setting
AIRFLOW__LOGGING__LOGGING_LEVEL=DEBUGis not enough for OpenLineage client to log on DEBUG level. I'm assuming it's because in OL client we uselogging.getLogger(__name__)that then fallbacks to root logger, and notairflowlogger or its descendants used and configured in AF3? As we can't tie the OL client directly with Airflow logging in the OL client's code - we explicitly propagate Airflow logging level from the OL provider to OL client, if OL client's logging level is not already set explicitly by the user. This looks like easy and foolproof solution so that the users debugging OpenLineage can still do so with use of single variable:AIRFLOW__LOGGING__LOGGING_LEVELwithout the need to manually specifyOPENLINEAGE_CLIENT_LOGGING.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.