[Internal API][only 2.10] Fixed setting rendered_map_index via internal api #49057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
added
type:bug-fix
Contributor
|
Note, this links to #48571 correct? |
jscheffl
approved these changes
Apr 11, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
THat totally makes sense... how could I over-look this last time during review. rendered_map_index is not depending on note content :-D
Contributor
|
CI Problems are un-related to the PR. Merging |
bugraoz93
approved these changes
Apr 11, 2025
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes an issue with the current rendered_map_index implementation. If map index is rendered during task execution and the rendered_map_index of the TI in DB is empty the refresh_from_db will reset the rendered_map_index to None. It is required before using the source to check that it is not none. Still checking only for Phydantic calss to affect only the internal api logic and not access old implementation.
Details of change: