Fix overwrite get_uri for JDBC
#48915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guan404ming
force-pushed
the
add-get-uri-for-jdbc
branch
from
f23e2b1 to
b1aec35
Compare
Lee-W
reviewed
Apr 9, 2025
guan404ming
force-pushed
the
add-get-uri-for-jdbc
branch
3 times, most recently
from
bb61060 to
a415551
Compare
guan404ming
force-pushed
the
add-get-uri-for-jdbc
branch
from
a415551 to
38a46ed
Compare
guan404ming
force-pushed
the
add-get-uri-for-jdbc
branch
from
38a46ed to
23ac206
Compare
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Member
Author
|
Thanks for reviewing! |
56 tasks
guan404ming
changed the title
get_uri for JDBCget_uri for JDBC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Towards #38195
Why
The current implementation of
DbApiHook.get_uri()incorrectly assumes that Airflow Connection URI representation is a valid SQLAlchemy URI, which is not always true. This assumption works in simple cases but fails in more complex scenarios.For JDBC connections specifically, the entire JDBC URL is stored in the "host" field of the connection, which follows a completely different format than standard SQLAlchemy URIs.
How
DbApiHook.get_urimethod within JdbcHook.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.