Clarify the Redshift delete cluster operator messaging. #48652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
bugraoz93
approved these changes
Apr 2, 2025
Contributor
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
Looks good! Make sense to use the cached property. Could you please update the test? It seems the delete cluster is failing
vincbeck
approved these changes
Apr 2, 2025
o-nikolas
approved these changes
Apr 2, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* Clarify the Redshift delete cluster operator messaging. * Fix tests for using conn instead of get_conn * Fix operator tests for using conn instead of get_conn * Fix overzealous find-and-replace
diogotrodrigues
pushed a commit
to diogotrodrigues/airflow
that referenced
this pull request
Apr 6, 2025
* Clarify the Redshift delete cluster operator messaging. * Fix tests for using conn instead of get_conn * Fix operator tests for using conn instead of get_conn * Fix overzealous find-and-replace
simonprydden
pushed a commit
to simonprydden/airflow
that referenced
this pull request
Apr 8, 2025
* Clarify the Redshift delete cluster operator messaging. * Fix tests for using conn instead of get_conn * Fix operator tests for using conn instead of get_conn * Fix overzealous find-and-replace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some confusion on the message phrasing in the operator. Attempted to clarify the message and since we're trying o use
conninstead ofget_conn(), I made those changes as well while I was in there.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.