Remove change_sensor_mode_to_reschedule from base executor #48649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no longer any single process executors so this field is not needed. This allows us to remove a runtime dependency of the task runner on loading the executor class when running sensors which used to override the prepare_for_execution to load the executor class to check this field which is False in all supported executors.
jaketf
requested review from
XD-DENG,
amoghrajesh,
ashb,
hussein-awala,
jedcunningham,
kaxil,
o-nikolas and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:Executors-core
ashb
approved these changes
Apr 1, 2025
ashb
removed
area:providers
provider:cncf-kubernetes
ashb
reviewed
Apr 1, 2025
providers/celery/src/airflow/providers/celery/executors/celery_kubernetes_executor.py
Show resolved
Hide resolved
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
) There are no longer any single process executors so this field is not needed. This allows us to remove a runtime dependency of the task runner on loading the executor class when running sensors which used to override the prepare_for_execution to load the executor class to check this field which is False in all supported executors.
diogotrodrigues
pushed a commit
to diogotrodrigues/airflow
that referenced
this pull request
Apr 6, 2025
) There are no longer any single process executors so this field is not needed. This allows us to remove a runtime dependency of the task runner on loading the executor class when running sensors which used to override the prepare_for_execution to load the executor class to check this field which is False in all supported executors.
simonprydden
pushed a commit
to simonprydden/airflow
that referenced
this pull request
Apr 8, 2025
) There are no longer any single process executors so this field is not needed. This allows us to remove a runtime dependency of the task runner on loading the executor class when running sensors which used to override the prepare_for_execution to load the executor class to check this field which is False in all supported executors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no longer any single process executors so this field is not needed.
This field is False in existing executors, which means we currently have a runtime dependency in the task runner on the executor just to check a field that is always false and does nothing.
This allows us to remove this runtime dependency of the task runner on loading the executor class when running sensors which used to override the
prepare_for_executionto load the executor class to perform this no longer necessary check