HttpHook: allways add port if given #48573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
For context: the little bug that this PR is fixing, renders Airflow 2.10.5 useless unless I change all Http connections and later change them back once this unexpected behavior (that the port now has to be included in the hostname (although connections have a port property) is changed again... Let me know if you require a test for proceeding with this PR... |
potiuk
reviewed
Apr 6, 2025
potiuk
approved these changes
Apr 6, 2025
potiuk
approved these changes
Apr 16, 2025
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently (Airflow 2.10.5)
HttpOperatortasks fail if theconnection_idused contains the port number as a parameter. The port number does not get included in thebase_urlif thehostconnection parameter contains thescheme(e.g. https://).It seems 71fec4e caused a behavioral change to HttpHook / HttpOperator....
This small change addresses the issue. It should be backported to Airflow version 2.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.