Remove fab from preinstalled providers #48457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I dont think we can rely on tests to test whether fab needs to be preinstalled. As far as I know the CI image is built using sources, so fab is still in the image. @potiuk do you have any idea on how we could test that? |
vincbeck
force-pushed
the
vincbeck/fab_optional
branch
from
2bc6fbb to
d29333c
Compare
Member
|
After #48223 it will be much more straightforward - you will be aable to easily see/test what breaks with |
Contributor
Author
Nice :) |
vincbeck
force-pushed
the
vincbeck/fab_optional
branch
from
d29333c to
b9b8674
Compare
vincbeck
added
the
full tests needed
Contributor
Author
|
Running all tests |
vincbeck
force-pushed
the
vincbeck/fab_optional
branch
3 times, most recently
from
e2e8e0b to
e2fb668
Compare
vincbeck
commented
Apr 4, 2025
vincbeck
force-pushed
the
vincbeck/fab_optional
branch
from
e2fb668 to
da8d034
Compare
vincbeck
force-pushed
the
vincbeck/fab_optional
branch
9 times, most recently
from
8001bd7 to
54ebe53
Compare
vincbeck
force-pushed
the
vincbeck/fab_optional
branch
from
54ebe53 to
d566117
Compare
vincbeck
requested review from
bolkedebruin,
ephraimbuddy and
potiuk
as code owners
vincbeck
requested review from
Fokko,
ashb,
dstandish,
eladkal,
gopidesupavan,
hussein-awala,
jedcunningham,
josh-fell,
jscheffl,
mik-laj,
mobuchowski and
o-nikolas
as code owners
o-nikolas
approved these changes
Apr 7, 2025
Contributor
Author
|
All tests are passing 🎉 |
potiuk
approved these changes
Apr 7, 2025
simonprydden
pushed a commit
to simonprydden/airflow
that referenced
this pull request
Apr 8, 2025
Member
|
The move of serve_logs to FAB is not right @potiuk @vincbeck . Serve logs is called automatically by the celery executor, which means that Celery worker now will not run without FAB installed. Even worse, it's called in the same way by the triggerer. FAB != Flask. Serve logs should not have been moved like this. Any chance either of you can fix this before we were hoping to cut the RC2 tomorrow? |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Apr 10, 2025
The `serve_logs` has been moved in apache#48457 to fab provider by mistake. It should remain in the airflow-core. We still depend on flask in the core (but as a next step we can replace it by starlette and unicorn). Fixes: apache#49028
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Apr 10, 2025
The `serve_logs` has been moved in apache#48457 to fab provider by mistake. It should remain in the airflow-core. We still depend on flask in the core (but as a next step we can replace it by starlette and unicorn). Fixes: apache#49028
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Apr 10, 2025
The `serve_logs` has been moved in apache#48457 to fab provider by mistake. It should remain in the airflow-core. We still depend on flask in the core (but as a next step we can replace it by starlette and unicorn). Fixes: apache#49028
kaxil
pushed a commit
to potiuk/airflow
that referenced
this pull request
Apr 10, 2025
The `serve_logs` has been moved in apache#48457 to fab provider by mistake. It should remain in the airflow-core. We still depend on flask in the core (but as a next step we can replace it by starlette and unicorn). Fixes: apache#49028
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove fab from preinstalled providers.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.