Changed min version for common sql to 1.23.0 in apache-airflow-providers-postgres #48416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low-providers-postgres
2 tasks
Contributor
|
I think we need to do this for all sql providers that import dialects? |
Contributor
Author
Only mssql and postgres depend on it, mssql is already correct |
eladkal
approved these changes
Mar 26, 2025
Contributor
|
You'll need to run pre-commit to fix the error. It generates additional file that you need to commit |
Contributor
|
You need to run the pre commits locally again :) |
…-apache-airflow-providers-postgres
Contributor
Author
Will redo it tonight ;-) |
…-apache-airflow-providers-postgres
…-apache-airflow-providers-postgres
…-apache-airflow-providers-postgres
…-apache-airflow-providers-postgres
potiuk
approved these changes
Mar 31, 2025
Member
|
Looks good. Thanks @dabla. The last failure was 143 (memory) I rea-run it. |
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Apr 2, 2025
…ers-postgres (apache#48416) * refactor: Changed min version for common sql to 1.23.0 in apache-airflow-providers-postgres * refactor: Updated provider dependencies * refactor: Updated apache-airflow-providers-common-sql min version --------- Co-authored-by: David Blain <david.blain@infrabel.be>
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…ers-postgres (apache#48416) * refactor: Changed min version for common sql to 1.23.0 in apache-airflow-providers-postgres * refactor: Updated provider dependencies * refactor: Updated apache-airflow-providers-common-sql min version --------- Co-authored-by: David Blain <david.blain@infrabel.be>
simonprydden
pushed a commit
to simonprydden/airflow
that referenced
this pull request
Apr 8, 2025
…ers-postgres (apache#48416) * refactor: Changed min version for common sql to 1.23.0 in apache-airflow-providers-postgres * refactor: Updated provider dependencies * refactor: Updated apache-airflow-providers-common-sql min version --------- Co-authored-by: David Blain <david.blain@infrabel.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed min version for common sql to 1.23.0 in apache-airflow-providers-postgres to fix ModuleNotFoundError: No module named 'airflow.providers.common.sql.dialects'
closes: #48381
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.