feat: Add fail_when_dag_is_paused param to TriggerDagRunOperator #48214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
reviewed
Apr 10, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
over all looks good. left some nits
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
Outdated
Show resolved
Hide resolved
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
Outdated
Show resolved
Hide resolved
baolsen
force-pushed
the
2025-03-24-trigger
branch
from
2522875 to
91187d3
Compare
Lee-W
reviewed
Apr 11, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
A few wording nitpicks, but in general looks good 🙂
providers/standard/tests/unit/standard/operators/test_trigger_dagrun.py
Outdated
Show resolved
Hide resolved
baolsen
force-pushed
the
2025-03-24-trigger
branch
from
6350cd5 to
f90e666
Compare
Lee-W
approved these changes
Apr 11, 2025
Contributor
Author
|
@Lee-W thanks for the review. Who can I ask to help with merging these changes in? |
Member
|
I'll keep it open for one or two days in case someone else wants to take a look. After that, I'll merge it |
jason810496
reviewed
Apr 14, 2025
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
Show resolved
Hide resolved
Contributor
|
@Lee-W you ok with merging this one? Do you see any issues? |
Contributor
|
cc @eladkal |
Member
LGTM on my end. minor issue. non-blocking |
jason810496
approved these changes
Apr 16, 2025
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional parameter to
TriggerDagRunOperatorto allow it to check if the triggered DAG is in a Paused state, and if so then fail the task.