Skip to content

Fix mypy boto3 appflow version #47912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 5 commits into from
Mar 19, 2025
Merged

Fix mypy boto3 appflow version #47912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6883851
refactor: remove type casting in AppflowHook update_flow method
Mar 18, 2025
61680f4
chore: update mypy-boto3-appflow dependency to version 1.37.0
Mar 18, 2025
cf99b9b
chore: update mypy-boto3-appflow dependency to version 1.37.0
Mar 18, 2025
5bdc68d
chore: update mypy-boto3-appflow dependency to version 1.37.0
Mar 18, 2025
5e4ef42
Merge branch 'main' into Fix-mypy-boto3-appflow-version
rawwar Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generated/provider_dependencies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"aiobotocore>=2.13.0",
"aws_xray_sdk>=2.12.0",
"moto[cloudformation,glue]>=5.0.0",
"mypy-boto3-appflow>=1.35.39",
"mypy-boto3-appflow>=1.37.0",
"mypy-boto3-rds>=1.34.90",
"mypy-boto3-redshift-data>=1.34.0",
"mypy-boto3-s3>=1.34.90",
Expand Down
2 changes: 1 addition & 1 deletion providers/amazon/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ dev = [
"aiobotocore>=2.13.0",
"aws_xray_sdk>=2.12.0",
"moto[cloudformation,glue]>=5.0.0",
"mypy-boto3-appflow>=1.35.39",
"mypy-boto3-appflow>=1.37.0",
"mypy-boto3-rds>=1.34.90",
"mypy-boto3-redshift-data>=1.34.0",
"mypy-boto3-s3>=1.34.90",
Expand Down
20 changes: 5 additions & 15 deletions providers/amazon/src/airflow/providers/amazon/aws/hooks/appflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,7 @@
# under the License.
from __future__ import annotations

from collections.abc import Sequence
from typing import TYPE_CHECKING, cast

from mypy_boto3_appflow.type_defs import (
DestinationFlowConfigTypeDef,
SourceFlowConfigTypeDef,
TaskTypeDef,
TriggerConfigTypeDef,
)
from typing import TYPE_CHECKING

from airflow.providers.amazon.aws.hooks.base_aws import AwsGenericHook
from airflow.providers.amazon.aws.utils.waiter_with_logging import wait
Expand Down Expand Up @@ -125,11 +117,9 @@ def update_flow_filter(self, flow_name: str, filter_tasks, set_trigger_ondemand:

self.conn.update_flow(
flowName=response["flowName"],
destinationFlowConfigList=cast(
Sequence[DestinationFlowConfigTypeDef], response["destinationFlowConfigList"]
),
sourceFlowConfig=cast(SourceFlowConfigTypeDef, response["sourceFlowConfig"]),
triggerConfig=cast(TriggerConfigTypeDef, response["triggerConfig"]),
destinationFlowConfigList=response["destinationFlowConfigList"],
sourceFlowConfig=response["sourceFlowConfig"],
triggerConfig=response["triggerConfig"],
description=response.get("description", "Flow description."),
tasks=cast(Sequence[TaskTypeDef], tasks),
tasks=tasks,
)
2 changes: 1 addition & 1 deletion providers/amazon/src/airflow/providers/amazon/get_provider_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1411,7 +1411,7 @@ def get_provider_info():
"aiobotocore>=2.13.0",
"aws_xray_sdk>=2.12.0",
"moto[cloudformation,glue]>=5.0.0",
"mypy-boto3-appflow>=1.35.39",
"mypy-boto3-appflow>=1.37.0",
"mypy-boto3-rds>=1.34.90",
"mypy-boto3-redshift-data>=1.34.0",
"mypy-boto3-s3>=1.34.90",
Expand Down