AIP-84 - add auth to dag report #47842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
One issue here. So, DagBag will read all files in the DAG_DIR and also example dags(because we set config include example dags in the test) . But, it does not sync to DB. Because of this, readable_dags_filter(which queries DagModel to fetch dag_id's) will be empty. I am trying to figure out how to update DB with the example_dags + available dags in the test. Also, code needs some refactoring. Which I'll do once I figure out above issue. |
Contributor
Author
|
I found EDIT: This worked. |
rawwar
commented
Mar 17, 2025
Lee-W
force-pushed
the
kalyan/AIP-84/auth/dag_report
branch
from
f748335 to
00c7ad7
Compare
Lee-W
approved these changes
Mar 17, 2025
Lee-W
reviewed
Mar 17, 2025
47 tasks
pierrejeambrun
approved these changes
Mar 17, 2025
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 21, 2025
* add auth to dag report * sync dags to DB * refactor * refactor(api_fastapi): rewrite dag_report filtering --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* add auth to dag report * sync dags to DB * refactor * refactor(api_fastapi): rewrite dag_report filtering --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #42360