[Internal API][only 2.10] Fix issue that task instance note field not possible to set via the internal api. #47769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutomationDev85
requested review from
XD-DENG,
ashb,
bolkedebruin and
kaxil
as code owners
AutomationDev85
changed the title
bugraoz93
reviewed
Mar 14, 2025
Contributor
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
Could you please add a test case when the source is TaskInstancePydantic?
AutomationDev85
force-pushed
the
bugfix/allow-internal-api-to-update-note-field
branch
from
4d459f4 to
306b734
Compare
bugraoz93
approved these changes
Mar 18, 2025
Contributor
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
Look good to me! Thanks for the detailed description and including the tests!
Contributor
|
@AutomationDev85 Test looks good from code but fails in details. I suspect that in the setup of pytest you need to sync the mocked data to the DB before you run the test, else in the test execution the internal API backend can not find the mock data in DB. |
AutomationDev85
force-pushed
the
bugfix/allow-internal-api-to-update-note-field
branch
from
7e115da to
0a3b2fb
Compare
Contributor
Author
|
@jscheffl Thanks for the tip. I changed the test case. |
Contributor
|
Errors are un-related to this PR, therefore merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the issue that it is not possible to set the task instance note field view the internal api. Without this the Edge worker is not able to update the note filed of the task_instance. To fix this the TaskInstancePydantic model was updated with the note field and the function which converts sets the ti attributes to convert pydantic into TaskInstance set the note field. This enables the Edge worker to set the note field of an task instance. This is pointing to only to the 2.10 test branch as the code will be complete change in Airflow 3.
Details of change: