[v2-11-test] Ensure that the the generated airflow.cfg contains a ran… #47755
+61
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
jscheffl
force-pushed
the
backport-106b872-v2-10-test
branch
from
81c710d to
55b4ea2
Compare
jscheffl
force-pushed
the
backport-106b872-v2-10-test
branch
from
55b4ea2 to
4c11b56
Compare
jscheffl
force-pushed
the
backport-106b872-v2-10-test
branch
from
4c11b56 to
dce0e57
Compare
Member
|
Could you fix the failing test @jscheffl ? |
kaxil
changed the title
Contributor
Author
|
@kaxil oh, lost focus on this one. Let me attempt to re-base and get it fixed. Jarek had a few fixes for docs on the branch... |
…dom jwt_secret and fernet_key (apache#46966) * Ensure that the the generated airflow.cfg contains a random jwt_secret and fernet_key I don't know exactly when this got broken, and unforutnaltey it wasn't tested, but I suspect it might have been around the time we swapped the default config from a config file to the yaml based values. I.e. a while ago! To make sure it doesn't get broken I've gone and added some unit tests And to make my next PR and test easier I have done the same thing with the `auth_jwt_secret` that we do for fernet_key -- of only set it in the config file if we're generating that file, not always in memory. * Improve upgrade path by generating and warning about the missing config (cherry picked from commit 106b872) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
jscheffl
force-pushed
the
backport-106b872-v2-10-test
branch
from
dce0e57 to
5addf0c
Compare
Member
|
Test failure:
|
Contributor
Author
|
@kaxil I hope now I make it... |
kaxil
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dom jwt_secret and fernet_key (#46966)
Backport with adjustments to v2-11-test