Use structlog for GitDagBundle #47685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
changed the title
ephraimbuddy
approved these changes
Mar 12, 2025
When working on stale bundle cleanup I experimented with structlog and added some logging that used its bind feature. I later removed the structlog part of it because I was not sure it would make it into 3.0. To keep the debug key-values I added a helper. We can remove it now that structlog is expected to be in 3.0.
dstandish
force-pushed
the
switch-back-to-structlog-from-log_debug-helper
branch
from
24ab3e9 to
6f5e39b
Compare
jedcunningham
approved these changes
Mar 12, 2025
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 21, 2025
When working on stale bundle cleanup I experimented with structlog and added some logging that used its bind feature. I later removed the structlog part of it because I was not sure it would make it into 3.0. To keep the debug key-values I added a helper. We can remove it now that structlog is expected to be in 3.0.
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
When working on stale bundle cleanup I experimented with structlog and added some logging that used its bind feature. I later removed the structlog part of it because I was not sure it would make it into 3.0. To keep the debug key-values I added a helper. We can remove it now that structlog is expected to be in 3.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on stale bundle cleanup I experimented with structlog and added some logging that used its bind feature. I later removed the structlog part of it because I was not sure it would make it into 3.0. To keep the debug key-values I added a helper. We can remove it now that structlog is expected to be in 3.0.
Also, remove logging mixin and just use structlog.