Handle null logical date in TimeDeltaSensorAsync #47652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
approved these changes
Mar 12, 2025
providers/standard/src/airflow/providers/standard/sensors/time_delta.py
Outdated
Show resolved
Hide resolved
Member
jedcunningham
left a comment
jedcunningham
left a comment
There was a problem hiding this comment.
Feels like we should test this?
providers/standard/src/airflow/providers/standard/sensors/time_delta.py
Outdated
Show resolved
Hide resolved
kaxil
force-pushed
the
time-delta-async-handle-logical-date-null
branch
from
05326e3 to
0dbdc55
Compare
Member
|
Is this ready @dstandish ? I just rebased it to fix CI failures that were fixed in main |
Contributor
Author
think so. added tests. |
sunank200
approved these changes
Mar 14, 2025
dstandish
force-pushed
the
time-delta-async-handle-logical-date-null
branch
from
0dbdc55 to
d03d464
Compare
We can use run_after in this case.
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
dstandish
force-pushed
the
time-delta-async-handle-logical-date-null
branch
from
e0f6585 to
0125087
Compare
eladkal
approved these changes
Mar 17, 2025
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 21, 2025
We can use run_after in this case. Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
We can use run_after in this case. Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use run_after in this case.
Closes: #47384