-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Switch asset decorator to use the DAG class in SDK #47602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following test failures should have an easy fix possibly i.e. changing the following mock to SDK DAG
|
fca337e to
450e888
Compare
|
I just rebased the PR too to eliminate issues with |
|
Yeah I think the most problematic part here is where we load example dags into DagBag for tests. Tests just send things in that DagBag directly into the scheduler, but the scheduler expects the DAG class in There are a couple of other failures but they are all pretty trivial like the one you mentioned. Relatedly, we currently do not have example DAGs that use the SDK. This would have been surfaced sooner if we added at least one. |
450e888 to
e67b652
Compare
Yeah we have some here https://github.com/apache/airflow/tree/main/task-sdk/tests/task_sdk/dags but we have not changed all the example_dags in the https://github.com/apache/airflow/tree/main/airflow/example_dags folder |
e67b652 to
dd5c3f7
Compare
467ca8e to
76956d5
Compare
9c59b13 to
4921932
Compare
4921932 to
0225a06
Compare
0225a06 to
67bc81f
Compare
This does not work just yet because the example dags test is not set up correctly and cannot handle the SDK's DAG class.
67bc81f to
0126850
Compare
|
This should now work! |
|
unrelated failures |
This does not work just yet because the example dags test is not set up correctly and cannot handle the SDK's DAG class.
WIP.