make bundle_name not nullable #47592

gyli · 2025-03-11T02:46:52Z

Change bundle_name in dag not nullable and prepopulate the value in the migration: #46734

Closes: #46734

airflow/migrations/versions/0050_3_0_0_add_dagbundlemodel.py

remove migration query Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>

airflow/migrations/versions/0050_3_0_0_add_dagbundlemodel.py

…ue46734

airflow/migrations/versions/0050_3_0_0_add_dagbundlemodel.py

gyli · 2025-05-05T04:05:41Z

Hi @ephraimbuddy @jedcunningham Do you think this PR looks good already, or you think more testing needs to be done?

ephraimbuddy · 2025-05-05T07:30:48Z

Hi @ephraimbuddy @jedcunningham Do you think this PR looks good already, or you think more testing needs to be done?

Since Airflow 3 has been released, we should update the PR with new migration file instead of editing the add-dagbundlemodel migration file. Sorry that it didn't make it to 3.0.0

gyli · 2025-05-06T22:00:48Z

PR is updated to use new migration file, as 3.0 is rolled out.

airflow-core/src/airflow/migrations/versions/0069_3_1_0_make_bundle_name_not_nullable.py

…undle_name_not_nullable.py Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>

airflow-core/src/airflow/migrations/versions/0069_3_1_0_make_bundle_name_not_nullable.py

…undle_name_not_nullable.py Update downgrade Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>

gyli · 2025-07-19T20:54:41Z

Hi @jedcunningham, PR updated. All test functions now add dag bundle with fixture. For adding dag bundle in helper functions, DagBundleModel is still used to avoid creating dag bundle unnecessarily. Does it look good to you?

airflow-core/src/airflow/migrations/versions/0079_3_1_0_make_bundle_name_not_nullable.py

airflow-core/tests/unit/api_fastapi/common/db/test_dags.py

devel-common/src/tests_common/pytest_plugin.py

airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_import_error.py

providers/common/sql/tests/unit/common/sql/operators/test_sql.py

uranusjr · 2025-08-14T06:51:17Z

airflow-core/src/airflow/migrations/versions/0082_3_1_0_make_bundle_name_not_nullable.py

+                    ('example_dags'),
+                    ('dags-folder')


Not related to this PR at all, damn this mix of dash and underscore is an eye sore.

make bundle_name not nullable

c21dee7

gyli requested review from XD-DENG, ashb and ephraimbuddy as code owners March 11, 2025 02:46

boring-cyborg bot added the area:db-migrations PRs with DB migration label Mar 11, 2025

ephraimbuddy reviewed Mar 11, 2025

View reviewed changes

airflow/migrations/versions/0050_3_0_0_add_dagbundlemodel.py Outdated Show resolved Hide resolved

Apply suggestions from code review

24ba85b

remove migration query Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>

jedcunningham added the AIP-66: DAG Bundle/Manifest label Mar 12, 2025

jedcunningham added this to AIP-66: DAG Bundles & Parsing Mar 12, 2025

jedcunningham reviewed Mar 12, 2025

View reviewed changes

airflow/migrations/versions/0050_3_0_0_add_dagbundlemodel.py Outdated Show resolved Hide resolved

update erd

8431e2a

gyli requested a review from potiuk as a code owner March 15, 2025 22:24

GL added 2 commits March 15, 2025 18:25

update erd

b7013d3

Merge branch 'issue46734' of https://github.com/gyli/airflow into iss…

e2ce847

…ue46734

ephraimbuddy reviewed Mar 16, 2025

View reviewed changes

airflow/migrations/versions/0050_3_0_0_add_dagbundlemodel.py Outdated Show resolved Hide resolved

ephraimbuddy reviewed Mar 16, 2025

View reviewed changes

airflow/migrations/versions/0050_3_0_0_add_dagbundlemodel.py Outdated Show resolved Hide resolved

add existing_type

2da1068

jedcunningham moved this to In Progress in AIP-66: DAG Bundles & Parsing Mar 24, 2025

gyli requested review from ephraimbuddy and jedcunningham April 14, 2025 04:24

Guangyang Li added 3 commits May 5, 2025 23:39

merge main

5bf349d

add new revision

3b8bfa3

add new revision

ccc3205

ephraimbuddy reviewed May 8, 2025

View reviewed changes

airflow-core/src/airflow/migrations/versions/0069_3_1_0_make_bundle_name_not_nullable.py Outdated Show resolved Hide resolved

Update airflow-core/src/airflow/migrations/versions/0069_3_1_0_make_b…

2851fe6

…undle_name_not_nullable.py Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>

ephraimbuddy reviewed May 9, 2025

View reviewed changes

airflow-core/src/airflow/migrations/versions/0069_3_1_0_make_bundle_name_not_nullable.py Outdated Show resolved Hide resolved

Update airflow-core/src/airflow/migrations/versions/0069_3_1_0_make_b…

c65885f

…undle_name_not_nullable.py Update downgrade Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>

Guangyang Li added 6 commits July 24, 2025 00:09

merge main

9d96795

update migration number

5b55c41

merge main

ce85d40

remove unnecessary nondb test class

e2d4367

Merge branch 'main' of https://github.com/apache/airflow into issue46734

a0ff1fc

fix newly added test in test_dag_command.py

c93c032

uranusjr reviewed Jul 28, 2025

View reviewed changes

airflow-core/src/airflow/migrations/versions/0079_3_1_0_make_bundle_name_not_nullable.py Show resolved Hide resolved

uranusjr reviewed Jul 28, 2025

View reviewed changes

airflow-core/tests/unit/api_fastapi/common/db/test_dags.py Show resolved Hide resolved

uranusjr reviewed Jul 28, 2025

View reviewed changes

devel-common/src/tests_common/pytest_plugin.py Show resolved Hide resolved

jedcunningham reviewed Jul 28, 2025

View reviewed changes

airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_import_error.py Show resolved Hide resolved

providers/common/sql/tests/unit/common/sql/operators/test_sql.py Outdated Show resolved Hide resolved

Guangyang Li added 6 commits July 28, 2025 21:04

merge main

194c352

re-generate migration file

048c983

re-generate migration file

52027bc

merge main

a650d74

re-generate migration file

a2cc1c5

fix unit test

1d24321

ephraimbuddy approved these changes Aug 1, 2025

View reviewed changes

Merge branch 'main' into issue46734

0309268

phanikumv requested a review from uranusjr August 4, 2025 12:08

Guangyang Li added 3 commits August 6, 2025 23:40

merge main

ec2be26

merge main

5a3d1bb

re-generate migration file

dde0196

gyli requested a review from jedcunningham August 12, 2025 03:57

Guangyang Li added 2 commits August 13, 2025 00:17

merge main

54d7487

re-generate migration file

0a2aaa4

uranusjr reviewed Aug 14, 2025

View reviewed changes

uranusjr merged commit 1215818 into apache:main Aug 14, 2025
105 checks passed

github-project-automation bot moved this from In Progress to Done in AIP-66: DAG Bundles & Parsing Aug 14, 2025

eladkal mentioned this pull request Sep 5, 2025

Status of testing Providers that were prepared on September 05, 2025 #55285

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make bundle_name not nullable #47592

make bundle_name not nullable #47592

Uh oh!

gyli commented Mar 11, 2025 •

edited by eladkal

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gyli commented May 5, 2025

Uh oh!

ephraimbuddy commented May 5, 2025

Uh oh!

gyli commented May 6, 2025

Uh oh!

Uh oh!

Uh oh!

gyli commented Jul 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

uranusjr Aug 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

make bundle_name not nullable #47592

make bundle_name not nullable #47592

Uh oh!

Conversation

gyli commented Mar 11, 2025 • edited by eladkal Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gyli commented May 5, 2025

Uh oh!

ephraimbuddy commented May 5, 2025

Uh oh!

gyli commented May 6, 2025

Uh oh!

Uh oh!

Uh oh!

gyli commented Jul 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

uranusjr Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gyli commented Mar 11, 2025 •

edited by eladkal

Loading