-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Marking fab and common messaging as not ready #47581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks! I agree with fab. On common messaging, it is ready on my side but maybe @vikramkoka wants to update the documentation? |
|
We need to add the not-ready providers to be build and prepared for PROD image - even if they are not ready (currently they are not). This is why docker-compose and k8s tests fail because they are installing fab provider 1.5.3 as the "not-ready" fab provider is excluded |
|
Fixup is coming |
|
The fixup I added should help |
Intresting. So why it wasn't needed for edge provider? |
Because edge provider (unlike FAB) is not (currently) needed for Airflow to run - it's not even installed in PROD image. |
|
Rebased to latest version |
|
Test failure is not related to the PR. |
* Marking fab and common messaging as not ready * fix static checks * fixup! fix static checks --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
* Marking fab and common messaging as not ready * fix static checks * fixup! fix static checks --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Currently there is a miss match between what we should release and what is marked as ready.
Common messaging provider was merged as draft
fab 2.0 is not to be released till it's ready for Airflow 3.
@vincbeck @vikramkoka Whenever the providers are ready mark them as so and it will be released in the following wave. till then I'm marking them as not ready. Vikram note that we can release common messaging as 0.0.1 if you prefer (like we do with standard provider)