Skip to content

Add other executor tests to K8s tests #47472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 8, 2025
Merged

Add other executor tests to K8s tests #47472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef9eb99
Add other executor tests to K8s tests
jscheffl Mar 6, 2025
f00d0b9
Use all k8s tests
jscheffl Mar 6, 2025
cd4c291
Add missing dependency to airflow models
jscheffl Mar 7, 2025
28aeeb0
Mark LocalExecutor as XFail due to issue #47518
jscheffl Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1468,7 +1468,7 @@ def _run_tests(
f"[info]You can deploy airflow with {executor} by running:[/]\nbreeze k8s configure-cluster\nbreeze k8s deploy-airflow --multi-namespace-mode --executor {executor}"
)
return 1, f"Tests {kubectl_cluster_name}"
the_tests: list[str] = ["kubernetes_tests/test_kubernetes_executor.py::TestKubernetesExecutor"]
the_tests: list[str] = ["kubernetes_tests/"]
command_to_run = " ".join([quote(arg) for arg in ["python3", "-m", "pytest", *the_tests, *test_args]])
get_console(output).print(f"[info] Command to run:[/] {command_to_run}")
result = run_command(
Expand Down
6 changes: 5 additions & 1 deletion kubernetes_tests/test_other_executors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@
# Also, the skipping is necessary as there's no gain in running these tests in KubernetesExecutor
@pytest.mark.skipif(EXECUTOR == "KubernetesExecutor", reason="Does not run on KubernetesExecutor")
class TestCeleryAndLocalExecutor(BaseK8STest):
@pytest.mark.xfail(
EXECUTOR == "LocalExecutor",
reason="https://github.com/apache/airflow/issues/47518 needs to be fixed",
)
def test_integration_run_dag(self):
dag_id = "example_bash_operator"
dag_run_id, logical_date = self.start_job_in_kubernetes(dag_id, self.host)
Expand All @@ -56,7 +60,7 @@ def test_integration_run_dag(self):

@pytest.mark.xfail(
EXECUTOR == "LocalExecutor",
reason="https://github.com/apache/airflow/issues/44481 needs to be implemented",
reason="https://github.com/apache/airflow/issues/47518 needs to be fixed",
)
def test_integration_run_dag_with_scheduler_failure(self):
dag_id = "example_xcom"
Expand Down
1 change: 1 addition & 0 deletions scripts/ci/kubernetes/k8s_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
-e ./task-sdk
-e ./devel-common
-e ./providers/cncf/kubernetes
-e . # Need this until all airflow.models are migrated to Task SDK
Loading