-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Remove remaining pieces of k8s exec specific UI pages #47422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jedcunningham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍺
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! seems that it was intermittent failure, restarted the failing job.
|
Yep. looks good @o-nikolas |
Unfortunately one conflict has popped up 😭 I'll resolve that and merge once the build is green again |
|
Damn |
|
Moving fast. breaking things |
|
I may miss context. the intention is to remove the K8S spec tab from the UI? |
Haha yeah, it was one of my other PRs that caused the conflict so I can't complain to much 😆 |
The PR description has all the details/history, but the tl;dr is yes. The |
4c6a590 to
2f26ed0
Compare
|
Any further thoughts you want to add before we merge @eladkal? |
See this conversation for more context: #47322 (comment)
tl;dr: We have had one remaining executor coupling (re AIP-51, see 6a here) with the k8s executor having a UI page which renders the kube config. This coupling has stayed unfixed because we have had two options:
As far as I can tell this page has actually already been removed in the recent PR to deprecate the old UI in Airflow, and the kube config endpoint as not as yet been re-created in the new UI. So this PR simply removes some of the remaining bits and pieces that used to trigger that endpoint to be present.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.