Skip to content

Conversation

@o-nikolas
Copy link
Contributor

See this conversation for more context: #47322 (comment)

tl;dr: We have had one remaining executor coupling (re AIP-51, see 6a here) with the k8s executor having a UI page which renders the kube config. This coupling has stayed unfixed because we have had two options:

  1. Create a mechanism for all executors to vend UI pages. This has remained undone because we only have one example of this requirement so it doesn't seem to warrant the complexity and time it would take to build such a mechanism. Also, the state of UI in Airflow has been under flux in recent times.
  2. Drop support for the k8s use case, which would remove the requirement of building 1). But this is a breaking change and we have not found a right time to do it, until now :)

As far as I can tell this page has actually already been removed in the recent PR to deprecate the old UI in Airflow, and the kube config endpoint as not as yet been re-created in the new UI. So this PR simply removes some of the remaining bits and pieces that used to trigger that endpoint to be present.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Mar 5, 2025
Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! seems that it was intermittent failure, restarted the failing job.

@o-nikolas o-nikolas marked this pull request as ready for review March 6, 2025 18:35
@potiuk
Copy link
Member

potiuk commented Mar 6, 2025

Yep. looks good @o-nikolas

@o-nikolas
Copy link
Contributor Author

Yep. looks good @o-nikolas

Unfortunately one conflict has popped up 😭 I'll resolve that and merge once the build is green again

@potiuk
Copy link
Member

potiuk commented Mar 6, 2025

Damn

@potiuk
Copy link
Member

potiuk commented Mar 6, 2025

Moving fast. breaking things

@eladkal
Copy link
Contributor

eladkal commented Mar 6, 2025

I may miss context. the intention is to remove the K8S spec tab from the UI?

@o-nikolas
Copy link
Contributor Author

Moving fast. breaking things

Haha yeah, it was one of my other PRs that caused the conflict so I can't complain to much 😆

@o-nikolas
Copy link
Contributor Author

I may miss context. the intention is to remove the K8S spec tab from the UI?

The PR description has all the details/history, but the tl;dr is yes. The /rendered-k8s endpoint is actually already removed. This PR just removes some of the remaining config bits left behind.

@o-nikolas o-nikolas force-pushed the onikolas/remove_k8s_ui_page branch from 4c6a590 to 2f26ed0 Compare March 6, 2025 18:49
@o-nikolas
Copy link
Contributor Author

Any further thoughts you want to add before we merge @eladkal?

@eladkal eladkal merged commit a4388ac into apache:main Mar 7, 2025
89 checks passed
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants