Remove extra method for async hook getting on KubernetesPodTrigger
#47313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
insomnes
force-pushed
the
remove-k8s-trigger-extra-by-to-do
branch
4 times, most recently
from
e640986 to
3c5a738
Compare
Contributor
Author
|
Up |
insomnes
force-pushed
the
remove-k8s-trigger-extra-by-to-do
branch
8 times, most recently
from
b9e8f2b to
2fdf3c8
Compare
insomnes
force-pushed
the
remove-k8s-trigger-extra-by-to-do
branch
from
2fdf3c8 to
8ab3cee
Compare
jscheffl
approved these changes
Mar 16, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for cleaning the TODO - I think this is now really able to be cleaned
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 21, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the extra wrapper method for async hook getting by the TODO.
Found during #47187 .
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.