Adding comment explaining why we exclude 0.115.10 fastapi #47266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
reviewed
Mar 2, 2025
potiuk
requested changes
Mar 2, 2025
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
requesting changes to not accidentally merge it.
amoghrajesh
changed the title
potiuk
approved these changes
Mar 2, 2025
Member
|
Yep. This is cool now :) |
Member
|
And it works as expected: 
|
jscheffl
approved these changes
Mar 2, 2025
shahar1
pushed a commit
to shahar1/airflow
that referenced
this pull request
Mar 5, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47233 pinned fastapi due to a bug in 0.115.10. That bug has been fixed and 0.115.11 is released: https://github.com/fastapi/fastapi/releases/tag/0.115.11
This PR explains why we do it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.