[Helm Chart] Grant Airflow API Server Permission to Read Pod Logs #47212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
vatsrahul1001
changed the title
vatsrahul1001
requested review from
amoghrajesh and
jedcunningham
and removed request for
dstandish,
hussein-awala and
jedcunningham
ashb
approved these changes
Feb 28, 2025
amoghrajesh
reviewed
Feb 28, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
@vatsrahul1001 could we please add some tests under helm_tests?
enchant3dmango
approved these changes
Feb 28, 2025
Contributor
Author
@amoghrajesh updated the existing test |
jedcunningham
approved these changes
Mar 1, 2025
62 tasks
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During KE testing with helm we noticed API Server was unable to fetch logs from Kubernetes pods due to missing RBAC permissions.
Now:
Before
closes: #47200
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.