Skip to content

Conversation

@olegkachur-e
Copy link
Contributor

  • add system test
  • update docs
  • add sources to the build jar file

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Feb 28, 2025
@potiuk potiuk force-pushed the dataflow_java_streaming_test branch from 81f473b to 990a62f Compare February 28, 2025 19:50
@potiuk
Copy link
Member

potiuk commented Feb 28, 2025

Rebased but some init.py files should be added (pre-commit will do it automatically).

@olegkachur-e
Copy link
Contributor Author

olegkachur-e commented Mar 3, 2025

Rebased but some init.py files should be added (pre-commit will do it automatically).

@potiuk Thank you for the rebase!

I thought it's not quite correct to add init.py files into the Java sources, is there any way to exclude some resources folder from this check or another approach?

@potiuk
Copy link
Member

potiuk commented Mar 3, 2025

I thought it's not quite correct to add init.py files into the Java sources, is there any way to exclude some resources folder from this check or another approach?

Sure - look at the sources of check-providers-subpackages-init-file-exist -> they are all configured in .pre-commit.yml and the script run here is scripts/ci/pre_commit/check_providers_subpackages_all_have_init.py -> and yes there are some exclusions there, you can likely figure out how to add yours.

- add system test
- update docs
- add sources to the build jar file
@olegkachur-e olegkachur-e force-pushed the dataflow_java_streaming_test branch from 990a62f to 4b279a4 Compare March 3, 2025 21:18
@olegkachur-e olegkachur-e requested a review from ashb as a code owner March 3, 2025 21:18
@potiuk potiuk merged commit 2dcb15f into apache:main Mar 9, 2025
59 checks passed
azharizz pushed a commit to azharizz/airflow that referenced this pull request Mar 9, 2025
- add system test
- update docs
- add sources to the build jar file

Co-authored-by: Oleg Kachur <kachur@google.com>
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
- add system test
- update docs
- add sources to the build jar file

Co-authored-by: Oleg Kachur <kachur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants