Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Feb 28, 2025

  • mention that you should run pre-commit or breeze static-check command
  • mention that you need to run uv sync or pip install
  • mention that you need to rebuild breeze image

Add comment for all pyproject.toml (and regenerate all the provider build files) just before the dependencies section in all provider's pyproject toml files - to get contributors more likely to read the instructions.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@gopidesupavan gopidesupavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It updated all the provides because of schema change in template file?

@potiuk
Copy link
Member Author

potiuk commented Feb 28, 2025

It updated all the provides because of schema change in template file?

I manually run breeze release-management prepare-provider-documentation --reapply-templates-only --answer yes to apply them. This is doing the same as what release manager would do but without bumping version numbers and regenerating commit list and changelog entries, just applying templates and regenerating what is automaticlaly generated.

@potiuk potiuk force-pushed the better-documentation-about-updating-depenendencies branch from 8be307e to 6d62a3a Compare February 28, 2025 10:39
@raphaelauv
Copy link
Contributor

a small question , uv sync remove the "necessary" packages to run unit test out of breeze 'directly in IDE) , is there an option to have uv sync keep the test requirements ?

thanks

image

@potiuk
Copy link
Member Author

potiuk commented Feb 28, 2025

a small question , uv sync remove the "necessary" packages to run unit test out of breeze 'directly in IDE) , is there an option to have uv sync keep the test requirements ?

Yes --extra devel --extra devel-tests - it's explained in the contributing docs:

https://github.com/apache/airflow/blob/main/contributing-docs/07_local_virtualenv.rst#creating-virtualenvs-with-uv

And yes, it's not obvious, but as soon as I move tests-common to a real package (waited for www removal - I hope to do it today or during the weekend), we will have all the "devel" dependencies added automatically to dev dependency group, so we will no longer need those extras for uv sync.

This is one of the reasons I want to make tests-common a separate "real" distribution - because currently it's just a "package" in "airflow" and it requires the extra deps to be added.

@potiuk potiuk force-pushed the better-documentation-about-updating-depenendencies branch from 6d62a3a to 4bb5bda Compare February 28, 2025 12:09
@raphaelauv
Copy link
Contributor

thanks @potiuk 👍

* mention that you should run pre-commit or breeze static-check command
* mention that you need to run `uv sync` or `pip install`
* mention that you need to rebuild breeze image

Add comment for all pyproject.toml (and regenerate all the provider
build files) just before the dependencies section in all provider's
pyproject toml files - to get contributors more likely to read
the instructions.
@potiuk potiuk force-pushed the better-documentation-about-updating-depenendencies branch from 4bb5bda to 9bb2e28 Compare February 28, 2025 15:35
@potiuk potiuk requested a review from jscheffl as a code owner February 28, 2025 15:35
@potiuk potiuk merged commit 1addb55 into apache:main Feb 28, 2025
89 checks passed
@potiuk potiuk deleted the better-documentation-about-updating-depenendencies branch February 28, 2025 16:43
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
* mention that you should run pre-commit or breeze static-check command
* mention that you need to run `uv sync` or `pip install`
* mention that you need to rebuild breeze image

Add comment for all pyproject.toml (and regenerate all the provider
build files) just before the dependencies section in all provider's
pyproject toml files - to get contributors more likely to read
the instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants