-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Remove api_connexion
#47158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove api_connexion
#47158
Conversation
8e058f9 to
141df0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to update:
- FAB provider
- dev tools (pre-commit, selective checks, breeze release commands)
- Documentation (release process,etc.)
|
Yeah. There is a bit more to it - I tried to do it yesterday, but I realized that this needs a bit more careful removals and in some cases some replacements :) |
|
Most notably. Our
@pierrejeambrun -> is this also your thinking here. |
141df0b to
ae8f8f8
Compare
|
It's also used in the dag commands. |
Yeah for now I kept this file only in |
ae8f8f8 to
2db2b56
Compare
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, together with the WWW deletion PR this would have made 100k LoC deletion :-D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we keep this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@vincbeck Can you also move this PR to the apache/main repo such that I can push some fixes on it? |
As long as I can not push, this diff fixes breeze unit tests: |
2db2b56 to
497b33a
Compare
Good idea :) |
|
|
497b33a to
da5c94a
Compare
Here we are: #47171 |
I think updating the breeze release command to use the new
+100 |
Follow-up of #46942
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.