-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Make run_after optional as part of API for Trigger Dag Run #46967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b1ca2e4 to
ab83bb7
Compare
bugraoz93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
4d42d9a to
70e9ec7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll just mark it as 'request change' so we don't merge this by mistake because this will cause troubles on the UI in its current state.
The UI needs a non nullable date to work. before it was logical_date and a lot of things broke when we did the AIP-83 amendment.
To resolve that we agreed on using the run_after date because it's not supposed to be null. This will bring trouble on the UI side if this change go through, is that required, should we use another non nullable date for the UI ?
|
Can you update the title and description of this PR to say its for Trigger Dag Run? I was worried we were making it nullable everywhere for a second. |
I got confused too, disregard my previous comment, that's just for the Trigger API, looks good thanks. |
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Changed it. I should have been more clear in my title. |
70e9ec7 to
eb34e49
Compare
eb34e49 to
4fca770
Compare
Currently
run_afteris defaulted totimezone.utcnow()in API. Now it is changed to optional with values -data_interval_end or utcnow()in the logic.closes: #46650
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.