Fix Trigger Form with Empty Object Default #46872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
added
type:bug-fix
jscheffl
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
pierrejeambrun
approved these changes
Feb 19, 2025
bbovenzi
approved these changes
Feb 19, 2025
2 tasks
2 tasks
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last changes in trigger form created a regression that JSON/object entry fields with empty defaults are rendered empty. This causes errors if the object default is an empty dict (
{}) as this is not explicitly checked.A residual problem exists that if the object field is declared "required" and the field is empty == interpreted as
nullthen the required field highlighting fails in JavaScript as the hidden data field behind CodeMirror can not be focussed. This would be major rework and will only be fixed in Airflow 3 with the new trigger form.closes: #46858