Skip to content

Relaxing restriction on multi-lines in feature newsfragments #46681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amoghrajesh wants to merge 1 commit into from
Closed

Relaxing restriction on multi-lines in feature newsfragments #46681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/ci/pre_commit/newsfragments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,10 @@
continue

if change_type != "significant":
if change_type == "feature":
continue
if num_lines != 1:
print(f"Newsfragment {filename} can only have a single line.")
print(f"Newsfragment {filename} can only have a single line for {change_type}.")
failed = True
else:
# significant newsfragment
Expand Down
Loading