Chart - Introduce worker.extraPorts to expose additional ports to worker container #46679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorricks
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
Jorricks
changed the title
potiuk
approved these changes
Feb 12, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…ainer (apache#46679) Co-authored-by: jorrick <jorrick.sleijster@adyen.com>
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
The celery worker runs many different workloads. Depending on the size of your Celery worker, you could run anywhere from 1 to 100's of concurrent tasks. There is no resource isolation within a Celery worker and a single job could in theory (and in practice) consume most of the available CPU & Memory. There is AFAIK no monitoring in place which monitors existing processes and tracks this down to specific DAGs and Tasks.
Improving the visibility
We are trying a POC where we run a background process which continuously monitors the processes in the container, and based on the command of each process figures out what dag & task it belongs to. These metrics will be exposed as a prometheus endpoint, which needs an additional port.
Proposed change
.Values.workers.extraPortsto have the ability to expose an extra port on the Airflow worker container.