-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Remove 'allow_trigger_in_future' config #46663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'allow_trigger_in_future' config #46663
Conversation
A DAG run with logical date in the future can never be started now. This only affects schedule=None, which can only be triggered manually. Instead of using a future date, you can trigger with a None logical date whenever you want. A custom run_id can be supplied if you want it. If a date is needed, it can be passed as a DAG param instead.
7512fb1 to
6f52ec2
Compare
6f52ec2 to
3ac9945
Compare
|
I'll merge it and rebase it to #46460 once CI is green. |
A DAG run with logical date in the future can never be started now. This only affects schedule=None, which can only be triggered manually. Instead of using a future date, you can trigger with a None logical date whenever you want. A custom run_id can be supplied if you want it. If a date is needed, it can be passed as a DAG param instead.
|
Since we have renamed In my own use case, we organize dagruns using logical_date, and there are many template macros that rely on Regarding the suggestion "If a date is needed, it can be passed as a DAG param instead", this is not optimal because DAG param can't be a first class citizen in the UI. E.g. if we wanna filter by a date in the UI or sort dagruns by a date, we can't rely on a date that only resides in the param. Using logical_date for such purpose is exactly what "logical date" should be used for. If there are no objections, I don't mind putting up a PR to remove this limitation of not allowing future logical_date to execute. |
|
We have similar usecases and I fully agree with @yuqian90. |
A DAG run with logical date in the future can never be started now. This only affects schedule=None, which can only be triggered manually.
Instead of using a future date, you can trigger with a None logical date whenever you want. A custom run_id can be supplied if you want it. If a date is needed, it can be passed as a DAG param instead.