TriggerDagRunOperator by defaults set logical date as null #46633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
…unOperator-logical-date-default-value-null
…unOperator-logical-date-default-value-null
…unOperator-logical-date-default-value-null
…of github.com:astronomer/airflow into TriggerDagRunOperator-logical-date-default-value-null
…unOperator-logical-date-default-value-null
…of github.com:astronomer/airflow into TriggerDagRunOperator-logical-date-default-value-null
Contributor
Author
|
Test failing for AF2.9 and some MYQL and SQLITE tests. I will look into these |
uranusjr
reviewed
Feb 13, 2025
…of github.com:astronomer/airflow into TriggerDagRunOperator-logical-date-default-value-null
…of github.com:astronomer/airflow into TriggerDagRunOperator-logical-date-default-value-null
Lee-W
reviewed
Feb 14, 2025
providers/standard/src/airflow/providers/standard/triggers/external_task.py
Outdated
Show resolved
Hide resolved
providers/standard/src/airflow/providers/standard/triggers/external_task.py
Outdated
Show resolved
Hide resolved
providers/standard/src/airflow/providers/standard/triggers/external_task.py
Outdated
Show resolved
Hide resolved
providers/standard/src/airflow/providers/standard/triggers/external_task.py
Outdated
Show resolved
Hide resolved
…unOperator-logical-date-default-value-null
…of github.com:astronomer/airflow into TriggerDagRunOperator-logical-date-default-value-null
…unOperator-logical-date-default-value-null
Lee-W
reviewed
Feb 17, 2025
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
Show resolved
Hide resolved
providers/standard/src/airflow/providers/standard/triggers/external_task.py
Outdated
Show resolved
Hide resolved
Lee-W
approved these changes
Feb 17, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
Mostly good. left a few nitpicks
Member
|
I’m going to merge this now. The spelling issue is currently being discussion on the mailing list, and can be mass-replaced once we decide how to automatically detect them. |
uranusjr
deleted the
TriggerDagRunOperator-logical-date-default-value-null
branch
ntr
pushed a commit
to ntr/airflow
that referenced
this pull request
Feb 20, 2025
) * TriggerDagRunOperator can now will have default null as logical date * refactor deferrable code and also fix TriggerDagRunOperator tests * fix test_external_task.py * fix external_task tests + run_id changes in WorkflowTrigger * fix test_external_tasks * implementent review comments + fix 2.9 tests * fix test_external_tasks * fix static checks * fix test failure for mysql and sqlite * update dag_run_id in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #46190
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.