Align layout in trigger form with flexible form #46596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
jscheffl
force-pushed
the
feature/align-layout-in-trigger-form
branch
from
eeff561 to
4ca60f7
Compare
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Looks good.
Just a minor comment!
bbovenzi
approved these changes
Feb 14, 2025
Contributor
Author
|
Thanks @shubhamraj-git for pushing some changes! |
dantonbertuol
pushed a commit
to dantonbertuol/airflow
that referenced
this pull request
Feb 17, 2025
* Align layout in trigger form with flexible form * Align helper text for Run ID as well * Take out the editable markdown * Revert extraction of JavaScript * Fix layout inconsistency after merge with Logical Date upstream --------- Co-authored-by: shubhamraj-git <shubhamraj.osc@gmail.com> Co-authored-by: Shubham Raj <48172486+shubhamraj-git@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the flexible trigger form and also DAG run notes evolved on other screens, this is a small cleanup and UI polishing:
Before this PR
After this PR (updated after review comments)
...and after exiting the notes:
FYI @shubhamraj-git