Use run_id for ExternalDag and TriggerDagRun links #46546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
AIP-83
uranusjr
force-pushed
the
external-task-extra-link-use-run-id
branch
from
52af4dd to
e71fa32
Compare
uranusjr
changed the title
Airflow views already can handle run_id instead of logical_date in the URL query, so we no longer needs to use the logical_date anyway. We also do not need to fetch the TaskInstance object from db at all since ti_key has all the information available to fetch the RTIF data we need. Although the type hint on the corresponding RTIF function is changed, the runtime behaviour is actually unchanged (which means old versions of Airflow work just fine!) because TaskInstanceKey shares the same attribute name protocol as a reak TaskInstance.
uranusjr
force-pushed
the
external-task-extra-link-use-run-id
branch
from
e71fa32 to
d72dde2
Compare
Lee-W
approved these changes
Feb 10, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
Airflow views already can handle run_id instead of logical_date in the URL query, so we no longer needs to use the logical_date anyway. We also do not need to fetch the TaskInstance object from db at all since ti_key has all the information available to fetch the RTIF data we need. Although the type hint on the corresponding RTIF function is changed, the runtime behaviour is actually unchanged (which means old versions of Airflow work just fine!) because TaskInstanceKey shares the same attribute name protocol as a reak TaskInstance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Airflow views already can handle run_id instead of logical_date in the URL query, so we no longer needs to use the logical_date anyway. We also do not need to fetch the TaskInstance object from db at all since ti_key has all the information available to fetch the RTIF data we need.
Although the type hint on the corresponding RTIF function is changed, the runtime behaviour is actually unchanged (which means old versions of Airflow work just fine!) because TaskInstanceKey shares the same attribute name protocol as a real TaskInstance.