-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Remove deprecated get_link signature support #46415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated get_link signature support #46415
Conversation
|
Old signature: class MyOperatorLink(BaseOperatorLink):
def get_link(self, operator, dttm):
...New signature: class MyOperatorLink(BaseOperatorLink):
def get_link(self, operator, *, ti_key):
...Note that in the old signature, The migration tool should search files for subclasses of Ideally, the tool should check all entries defined in the Relevant documentation on operator extra link: https://airflow.apache.org/docs/apache-airflow/stable/howto/define-extra-link.html |
|
Delaying this a bit per discussion with @ashb. The task SDK work may need to change this. |
|
Got a go-ahead. We can progress now. |
0309a51 to
0c1a7ba
Compare
0c1a7ba to
a7e177a
Compare
Operator link currently supports two signatures, one modern using TaskInstanceKey, the other old using execution_date. The old signature will have a problem after the AIP-83 amendments where None is a possibility. Airflow 3.0 is a good chance to just get rid of this problem entirely. Although the signature is documented as deprecated, we currently do not emit any warnings for this. We'll need to add the warning to 2.11, and add a migration rule for it.
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
a7e177a to
018edef
Compare
* Remove deprecated get_link signature support Operator link currently supports two signatures, one modern using TaskInstanceKey, the other old using execution_date. The old signature will have a problem after the AIP-83 amendments where None is a possibility. Airflow 3.0 is a good chance to just get rid of this problem entirely. Although the signature is documented as deprecated, we currently do not emit any warnings for this. We'll need to add the warning to 2.11, and add a migration rule for it. Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Operator link currently supports two signatures, one modern using TaskInstanceKey, the other old using execution_date. The old signature will have a problem after the AIP-83 amendments where None is a possibility. Airflow 3.0 is a good chance to just get rid of this problem entirely.
TODO: