fix: OL sql parsing add try-except for sqlalchemy engine #46366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
Contributor
|
@kacpermuda are we sure nothing breaks when we don't pass the sqlalchemy_engine later? |
Contributor
Author
|
@mobuchowski This engine is used only here, in |
mobuchowski
approved these changes
Feb 3, 2025
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Feb 3, 2025
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 4, 2025
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add try/except for sql alchemy engine creation used in some google cloud operators (not in SQLExecuteQueryOperator). It's used only for query compilation within sql parser and it's not required, so i think this is reasonable. This issue came out when using CloudSQLExecuteQuery operator, and this is a quick fix before release happens.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.