BREAKING CHANGE: replace Airflow config by conx extras in SMTP provider #46219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
requested review from
ashb,
jedcunningham and
potiuk
as code owners
eladkal
reviewed
Jan 29, 2025
3 tasks
eladkal
approved these changes
Feb 2, 2025
Contributor
eladkal
left a comment
eladkal
left a comment
There was a problem hiding this comment.
Just needs to remove unrelated changes for mongo (as were already fixed in main)
Contributor
|
@hussein-awala can you rebase and resolve conflicts? |
hussein-awala
force-pushed
the
smtp_provider_configless
branch
from
9bf0bbe to
18d5a24
Compare
Member
Author
it's ready, I'll merge once the tests are green |
potiuk
approved these changes
Feb 5, 2025
potiuk
force-pushed
the
smtp_provider_configless
branch
from
e3ba5a4 to
de74223
Compare
eladkal
approved these changes
Feb 6, 2025
Contributor
|
Merging. Failures ade about Amazon DMS not related to this PR |
insomnes
pushed a commit
to insomnes/airflow
that referenced
this pull request
Feb 6, 2025
…pache#46219) * BREAKING CHANGE: replace Airflow config by conx extras in SMTP provider * fix static checks
insomnes
pushed a commit
to insomnes/airflow
that referenced
this pull request
Feb 6, 2025
…pache#46219) * BREAKING CHANGE: replace Airflow config by conx extras in SMTP provider * fix static checks
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…pache#46219) * BREAKING CHANGE: replace Airflow config by conx extras in SMTP provider * fix static checks
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…pache#46219) * BREAKING CHANGE: replace Airflow config by conx extras in SMTP provider * fix static checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some breaking changes to SMTP provider:
The argument
from_emailis now an optional kwarg inSmtpNotifier, and the argumenttobecame the first positional argument.Configuring the
SmtpNotifierandSmtpHookdefault values via Airflow SMTP configurations is not supported anymore. You can instead use the SMTP connection configuration to set the default values, where you can use:ssl_contextinstead of the configurationsmtp_provider.ssl_contextoremail.ssl_contextin the SMTP hook.from_emailinstead of the configurationsmtp.smtp_mail_frominSmtpNotifier.subject_templateinstead of the configurationsmtp.templated_email_subject_pathinSmtpNotifier.html_content_templateinstead of the configurationsmtp.templated_html_content_pathinSmtpNotifier.