-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add triggerer info and extra links section to task instance details tab. #46074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pierrejeambrun
merged 5 commits into
apache:main
from
tirkarthi:ti-triggerer-extra-links
Feb 5, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e6cf232
Add triggerer info and extra links section to task instance details tab.
tirkarthi d0a57eb
Change button variant from default solid to surface to make it lighter.
tirkarthi f86c136
Add map_index support.
tirkarthi eee3a8d
PR comments refactor.
tirkarthi 3646bf3
Add section name for task instance details.
tirkarthi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /*! | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import { Box, Button, Heading, HStack } from "@chakra-ui/react"; | ||
| import { useParams, useSearchParams } from "react-router-dom"; | ||
|
|
||
| import { useTaskInstanceServiceGetExtraLinks } from "openapi/queries"; | ||
|
|
||
| export const ExtraLinks = () => { | ||
| const { dagId = "", runId = "", taskId = "" } = useParams(); | ||
| const [searchParams] = useSearchParams(); | ||
| const mapIndexParam = searchParams.get("map_index"); | ||
| const mapIndex = parseInt(mapIndexParam ?? "-1", 10); | ||
|
|
||
| const { data } = useTaskInstanceServiceGetExtraLinks({ | ||
| dagId, | ||
| dagRunId: runId, | ||
| mapIndex, | ||
| taskId, | ||
| }); | ||
|
|
||
| return data && Object.keys(data).length > 0 ? ( | ||
| <Box py={1}> | ||
| <Heading size="sm"> Extra Links </Heading> | ||
| <HStack gap={2} py={2}> | ||
| {Object.entries(data).map(([key, value], _) => | ||
| value === null ? undefined : ( | ||
| <Button asChild colorPalette="blue" key={key} variant="surface"> | ||
| <a href={value} rel="noreferrer" target="_blank"> | ||
| {key} | ||
| </a> | ||
| </Button> | ||
| ), | ||
| )} | ||
| </HStack> | ||
| </Box> | ||
| ) : undefined; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /*! | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import { Box, Table, Heading } from "@chakra-ui/react"; | ||
|
|
||
| import type { TaskInstanceResponse } from "openapi/requests/types.gen"; | ||
| import Time from "src/components/Time"; | ||
|
|
||
| export const TriggererInfo = ({ taskInstance }: { readonly taskInstance: TaskInstanceResponse }) => ( | ||
| <Box py={1}> | ||
| <Heading py={1} size="sm"> | ||
| Triggerer Info | ||
| </Heading> | ||
| <Table.Root striped> | ||
| <Table.Body> | ||
| <Table.Row> | ||
| <Table.Cell>Trigger class</Table.Cell> | ||
| <Table.Cell>{taskInstance.trigger?.classpath}</Table.Cell> | ||
| </Table.Row> | ||
| <Table.Row> | ||
| <Table.Cell>Trigger ID</Table.Cell> | ||
| <Table.Cell>{taskInstance.trigger?.id}</Table.Cell> | ||
| </Table.Row> | ||
| <Table.Row> | ||
| <Table.Cell>Trigger creation time</Table.Cell> | ||
| <Table.Cell> | ||
| <Time datetime={taskInstance.trigger?.created_date} /> | ||
| </Table.Cell> | ||
| </Table.Row> | ||
| <Table.Row> | ||
| <Table.Cell>Assigned triggerer</Table.Cell> | ||
| <Table.Cell>{taskInstance.triggerer_job?.hostname}</Table.Cell> | ||
| </Table.Row> | ||
| <Table.Row> | ||
| <Table.Cell>Latest triggerer heartbeat</Table.Cell> | ||
| <Table.Cell> | ||
| <Time datetime={taskInstance.triggerer_job?.latest_heartbeat} /> | ||
| </Table.Cell> | ||
| </Table.Row> | ||
| </Table.Body> | ||
| </Table.Root> | ||
| </Box> | ||
| ); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pierrejeambrun @bbovenzi We should nix this "external" word here, as some of the values are "timetable", or "asset" which aren't external.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we always want to show
dagRun.triggered_bythen? instead of only on external triggers?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we decide on that we can maybe just remove the
Externalword from here as this is misleading:#46559