feat(task_sdk): add support for inlet_events in Task Context #45960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
force-pushed
the
add-asset-inlet-to-tasksdk
branch
from
3cb8fb4 to
6ac30c8
Compare
Lee-W
force-pushed
the
add-asset-inlet-to-tasksdk
branch
3 times, most recently
from
0c8da84 to
9460573
Compare
2 tasks
Lee-W
force-pushed
the
add-asset-inlet-to-tasksdk
branch
4 times, most recently
from
a267114 to
f613905
Compare
Member
Author
|
Hey @ashb and @amoghrajesh , could you please take a quick look at this PR? in case I'm doing something wrong regarding task_sdk. The tests are not fixed as of now. I'll work on that if the overall logic looks ok. Thanks! |
amoghrajesh
reviewed
Feb 19, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
General direction looking good, will take a better look with tests.
Member
Author
|
Thanks @amoghrajesh ! |
Lee-W
force-pushed
the
add-asset-inlet-to-tasksdk
branch
15 times, most recently
from
b5fe1d2 to
d07c722
Compare
Member
Author
|
it's green after rerun 🙌 |
amoghrajesh
approved these changes
Feb 28, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Almost there. Preemptively approving provided my comments are handled.
uranusjr
approved these changes
Mar 2, 2025
Lee-W
added
the
airflow3.0:breaking
Lee-W
force-pushed
the
add-asset-inlet-to-tasksdk
branch
from
cd49204 to
1cf88c4
Compare
Member
Author
|
@amoghrajesh I'll merge it this afternoon. Please let me know if you want to take a look again 🙂 |
shahar1
pushed a commit
to shahar1/airflow
that referenced
this pull request
Mar 5, 2025
…45960) * feat(task_sdk): add support for inlet_events in Task Context * feat(task_sdk): add AssetEventCollectionResponse * refactor(task_sdk): combine asset event uris * refactor(api_fastapi): extract asset_event datamodels from asset * fix(task_sdk): revert unrelated datamodels change * fix(task_sdk/context): add _get_asset_events_from_db for fixing tests * test(task_sdk): add test cases for execution_time context inlet access * test(task_sdk): extend test_handle_requests to include asset event calls * test(execution_api): add tests to asset event apis * fix(execution_api): remove unnecessary redact * feat(task_sdk): extract asset response from asset event response * feat(task_sdk): add missing http exception * feat(task_sdk): extract asset response from asset event response * feat(task_sdk): remove duplicate inlet logic * feat(task_sdk): remove AssetEvent form definitions * test(task_sdk): add test case test_run_with_asset_inlets * docs(newsfragments): add description of how inlet_events access has been changed
2 tasks
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…45960) * feat(task_sdk): add support for inlet_events in Task Context * feat(task_sdk): add AssetEventCollectionResponse * refactor(task_sdk): combine asset event uris * refactor(api_fastapi): extract asset_event datamodels from asset * fix(task_sdk): revert unrelated datamodels change * fix(task_sdk/context): add _get_asset_events_from_db for fixing tests * test(task_sdk): add test cases for execution_time context inlet access * test(task_sdk): extend test_handle_requests to include asset event calls * test(execution_api): add tests to asset event apis * fix(execution_api): remove unnecessary redact * feat(task_sdk): extract asset response from asset event response * feat(task_sdk): add missing http exception * feat(task_sdk): extract asset response from asset event response * feat(task_sdk): remove duplicate inlet logic * feat(task_sdk): remove AssetEvent form definitions * test(task_sdk): add test case test_run_with_asset_inlets * docs(newsfragments): add description of how inlet_events access has been changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We need to add support for inlet-events in task_sdk context as well.
What
InletEventsAccessorsfromairflow/utils/context.pytotask_sdk/src/airflow/sdk/execution_time/context.pySUPERVISOR_COMMSto retrieve asset eventsAssetEventResponse,DagRunAssetReferencedata models/asset-eventsroute with/by-asset-name-uri/by-asset-uri/by-asset-name/by-alias-nameAssetEventOperationsto handle the routingtask_sdk/src/airflow/sdk/execution_time/supervisor.pycloses: #45717
closes: #46852
closes: #46852
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.