Simplify TaskSDK's CommsDecoder interface #45927
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the uses cases of `send_request` are also followed by `get_message` -- so lets do that for users -- this makes it closer to an HTTP request too, where you send a request and get a request. Some message types don't have a response, so in order to know if we should call `get_message` or not we define a "marker" class of `NoResponseMessage`, and if we subclass that then we don't expect, and don't read anything back. The other option I considered was to have the supervisor always send a message back (i.e. send an empty line when there is otherwise no response to send) and have `get_message()` typed to be `ToTask | None`. It felt marginally better to have `get_message()` typed and behave to always expect a messsage.
amoghrajesh
requested review from
amoghrajesh and
kaxil
and removed request for
amoghrajesh
amoghrajesh
approved these changes
Jan 22, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
I like this approach better than having to change the get_message's typing. One comment, otherwise looks good
| @@ -265,7 +269,7 @@ class PutVariable(BaseModel): | |||
| type: Literal["PutVariable"] = "PutVariable" | |||
Contributor
There was a problem hiding this comment.
We should add for this one too?
Member
Author
|
I've changed my mind on this -- we should change everything to always have a resposne, even if that is |
Member
Author
|
I'm parking this change for now and will revisit it for fuller exception handling/propagation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the uses cases of
send_requestare also followed byget_message--so lets do that for users -- this makes it closer to an HTTP request too,
where you send a request and get a request.
Some message types don't have a response, so in order to know if we should
call
get_messageor not we define a "marker" class ofNoResponseMessage,and if we subclass that then we don't expect, and don't read anything back.
The other option I considered was to have the supervisor always send a message
back (i.e. send an empty line when there is otherwise no response to send) and
have
get_message()typed to beToTask | None. It felt marginally better tohave
get_message()typed and behave to always expect a messsage.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.