Fix failures on main related to DagRun validation #45917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
added
the
full tests needed
kaxil
force-pushed
the
fix-main-failures
branch
from
d2243a7 to
70d7f2b
Compare
|
Yes. I think we should run all provider tests when task_sdk files change. I will add it to selective checks. |
Lee-W
reviewed
Jan 22, 2025
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 22, 2025
When Task SDK sources change, provider code is impacted as they are using Task SDK - some tests might fail because of changes there. Example case: apache#45917
|
PR for selective checks to avoid such failures in the future #45921 |
kaxil
force-pushed
the
fix-main-failures
branch
from
70d7f2b to
51be7b2
Compare
potiuk
added a commit
that referenced
this pull request
Jan 22, 2025
When Task SDK sources change, provider code is impacted as they are using Task SDK - some tests might fail because of changes there. Example case: #45917
pierrejeambrun
approved these changes
Jan 22, 2025
kaxil
force-pushed
the
fix-main-failures
branch
from
9684ac4 to
480e54b
Compare
eladkal
approved these changes
Jan 22, 2025
kaxil
force-pushed
the
fix-main-failures
branch
from
480e54b to
459cbe6
Compare
|
ALMOST ! |
Some test failures like https://github.com/apache/airflow/actions/runs/12903540392/job/35979200770?pr=45865 were not caught in apache#45834 Follow-up of apache#45834
kaxil
force-pushed
the
fix-main-failures
branch
from
131816f to
33a6be7
Compare
Should be finally fully green 🤞 |
|
🤞 🤞 |
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
When Task SDK sources change, provider code is impacted as they are using Task SDK - some tests might fail because of changes there. Example case: apache#45917
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
Some test failures like https://github.com/apache/airflow/actions/runs/12903540392/job/35979200770?pr=45865 were not caught in apache#45834 Follow-up of apache#45834
utkarsharma2
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test failures like https://github.com/apache/airflow/actions/runs/12903540392/job/35979200770?pr=45865 were not caught in #45834
Follow-up of #45834
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.