-
Notifications
You must be signed in to change notification settings - Fork 16.4k
[v2-11-test] Resolve OOM When Reading Large Logs in Webserver #45914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7fe9b77
ab176bf
3226233
680a713
48debfe
54386ec
c6d4e5e
7e39433
5797341
e4e5a85
6cef899
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -872,16 +872,17 @@ def _process_executor_events(self, executor: BaseExecutor, session: Session) -> | |
|
|
||
| task_log_reader = TaskLogReader() | ||
| if task_log_reader.supports_read: | ||
| metadata: dict[str, Any] = {} | ||
| logs, metadata = task_log_reader.read_log_chunks(ti, ti.try_number, metadata) | ||
| if ti.hostname in dict(logs[0]): | ||
| message = str(dict(logs[0])[ti.hostname]).replace("\\n", "\n") | ||
| hosts, log_streams, metadata = task_log_reader.read_log_chunks( | ||
| ti, ti.try_number, None | ||
| ) | ||
| if ti.hostname in hosts: | ||
| message = str(next(iter(log_streams[0]))) | ||
| while metadata["end_of_log"] is False: | ||
| logs, metadata = task_log_reader.read_log_chunks( | ||
| hosts, log_streams, metadata = task_log_reader.read_log_chunks( | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this is a big change, I am afraid to include it in 2.11! For example, in this case where the return type of
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kaxil it seems he is intending this to go to 3.0 only
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah we should not spend time adding meaningful changes to 2.x
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I think changing the return type of |
||
| ti, ti.try_number - 1, metadata | ||
| ) | ||
| if ti.hostname in dict(logs[0]): | ||
| message = message + str(dict(logs[0])[ti.hostname]).replace("\\n", "\n") | ||
| if ti.hostname in hosts: | ||
| message = message + str(next(iter(log_streams[0]))) | ||
| if span.is_recording(): | ||
| span.add_event( | ||
| name="task_log", | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.