Add shortcut key support for search dags. #45908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
requested review from
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
jscheffl
reviewed
Jan 22, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
I attempted this and was not working. Also no tooltip was displayed (is this contained in the module?).
What is the modifier on a non-APple machine? (I used Linux/Ubuntu 24.04/Firefox+Chrome and CTRL+K was bringing me to browser search bar, not the UI entry box)
jscheffl
approved these changes
Jan 23, 2025
tirkarthi
force-pushed
the
hotkeys-search
branch
from
7e2d541 to
e8edee7
Compare
tirkarthi
force-pushed
the
hotkeys-search
branch
from
e8edee7 to
20920e2
Compare
Prab-27
pushed a commit
to Prab-27/airflow
that referenced
this pull request
Jan 31, 2025
* Add shortcut key support for search dags. * Display meta key for respective OS.
This was referenced Feb 5, 2025
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
* Add shortcut key support for search dags. * Display meta key for respective OS.
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
* Add shortcut key support for search dags. * Display meta key for respective OS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds "ctrl+k" as shortcut to open search dags modal in dag details page. The shortcut is similar to Chakra docs and other websites. The shortcut key is added to the button for reference.