Skip to content

Conversation

@raphaelauv
Copy link
Contributor

@raphaelauv raphaelauv commented Jan 10, 2025

closes: #44325

@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Jan 10, 2025
@raphaelauv raphaelauv force-pushed the fix/kpo_kubeconfig_path_async branch 2 times, most recently from 7d85aff to f6e0502 Compare January 10, 2025 22:48
@raphaelauv raphaelauv marked this pull request as draft January 11, 2025 11:35
@raphaelauv raphaelauv force-pushed the fix/kpo_kubeconfig_path_async branch from f6e0502 to e38a66c Compare January 12, 2025 15:26
@raphaelauv raphaelauv marked this pull request as ready for review January 12, 2025 15:27
@raphaelauv raphaelauv force-pushed the fix/kpo_kubeconfig_path_async branch 2 times, most recently from 7e297e5 to 5555916 Compare January 13, 2025 10:18
@raphaelauv
Copy link
Contributor Author

@romsharon98 @amoghrajesh gentle ping :)

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it should fix the issue, I just added a comment to reduce redundant code.

@raphaelauv
Copy link
Contributor Author

@romsharon98 @amoghrajesh gentle ping :)

@raphaelauv raphaelauv force-pushed the fix/kpo_kubeconfig_path_async branch from 5555916 to 237bde7 Compare February 7, 2025 09:42
@raphaelauv
Copy link
Contributor Author

hi @eladkal , could you pls review , thanks

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hussein-awala hussein-awala merged commit ae46b9e into apache:main Feb 7, 2025
71 checks passed
@raphaelauv raphaelauv deleted the fix/kpo_kubeconfig_path_async branch February 7, 2025 14:24
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KPO async - kube_config_path not supported

2 participants