Updated instantiation of httpx AsyncClient in KiotaRequestAdapterHook to be httpx 0.28.x compliant #45464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameter is deprecated and mounts parameter should be used instead
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
eladkal
approved these changes
Jan 8, 2025
Contributor
Author
|
Thanks @eladkal |
dstandish
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jan 8, 2025
…rameter is deprecated and mounts parameter should be used instead (apache#45464) Co-authored-by: David Blain <david.blain@infrabel.be>
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
…rameter is deprecated and mounts parameter should be used instead (apache#45464) Co-authored-by: David Blain <david.blain@infrabel.be>
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…rameter is deprecated and mounts parameter should be used instead (apache#45464) Co-authored-by: David Blain <david.blain@infrabel.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From httpx 0.28.0 and higher, the deprecated 'proxies' parameter of the AsyncClient won't be available anymore and has been replaced with the 'mounts' parameter. At the moment this isn't an issue yet as Airflow is still using 0.27.x but could become a problem in the future once Airflow would start using httpx 0.28.0 or higher.
The httpx AsyncClient is being used by the KiotaRequestAdapterHook in the Microsoft Azure provider, so to avoid any upgrade issues in the future I've fixed the instantiation of the AsyncClient.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.