-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Introduce operation helper class and refactor Google provider hooks #45354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a19a89b to
5314925
Compare
Contributor
|
@potiuk could you please check this PR? |
5314925 to
1aca9cc
Compare
eladkal
reviewed
Jan 8, 2025
providers/src/airflow/providers/google/common/hooks/operation_helpers.py
Show resolved
Hide resolved
39d0c0b to
2242dde
Compare
Member
|
There are some conflicts to be resolved and we are about to migrate Google provider to the new provider structure, so you will have to rebase it and adapt to the moved files. |
2e8fdee to
041bfe1
Compare
9e647cb to
ea9a00b
Compare
abc111a to
20b979f
Compare
Member
|
Static checks failing. |
708e822 to
d2d0278
Compare
- Refactor google cloud hooks, that used generic 'wait_for_operation' methods.
d2d0278 to
f8d2c28
Compare
Contributor
potiuk
approved these changes
Mar 13, 2025
Member
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice DRY improvement :)
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
- Refactor google cloud hooks, that used generic 'wait_for_operation' methods. Co-authored-by: Oleg Kachur <kachur@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.