Skip to content

Conversation

@olegkachur-e
Copy link
Contributor

  • Refactor google cloud hooks, that used generic 'wait_for_operation' methods.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jan 2, 2025
@olegkachur-e olegkachur-e force-pushed the refactor_wait_operation branch from a19a89b to 5314925 Compare January 2, 2025 14:55
@MaksYermak
Copy link
Contributor

@potiuk could you please check this PR?

@olegkachur-e olegkachur-e force-pushed the refactor_wait_operation branch from 5314925 to 1aca9cc Compare January 8, 2025 00:00
@olegkachur-e olegkachur-e force-pushed the refactor_wait_operation branch 2 times, most recently from 39d0c0b to 2242dde Compare January 9, 2025 12:10
@olegkachur-e olegkachur-e requested a review from eladkal January 10, 2025 14:28
@potiuk
Copy link
Member

potiuk commented Feb 1, 2025

There are some conflicts to be resolved and we are about to migrate Google provider to the new provider structure, so you will have to rebase it and adapt to the moved files.

@olegkachur-e olegkachur-e force-pushed the refactor_wait_operation branch 6 times, most recently from 2e8fdee to 041bfe1 Compare February 12, 2025 22:49
@olegkachur-e olegkachur-e force-pushed the refactor_wait_operation branch 4 times, most recently from 9e647cb to ea9a00b Compare February 20, 2025 16:39
@olegkachur-e olegkachur-e force-pushed the refactor_wait_operation branch 3 times, most recently from abc111a to 20b979f Compare March 3, 2025 22:02
@potiuk
Copy link
Member

potiuk commented Mar 4, 2025

Static checks failing.

@olegkachur-e olegkachur-e force-pushed the refactor_wait_operation branch 3 times, most recently from 708e822 to d2d0278 Compare March 10, 2025 22:24
- Refactor google cloud hooks, that used generic 'wait_for_operation'
methods.
@olegkachur-e olegkachur-e force-pushed the refactor_wait_operation branch from d2d0278 to f8d2c28 Compare March 11, 2025 17:59
@VladaZakharova
Copy link
Contributor

hi @potiuk and @eladkal !
Can you please check changes here? All the conflicts are resolved and i think this change will help google provider to improve :)

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice DRY improvement :)

@potiuk potiuk merged commit 2862775 into apache:main Mar 13, 2025
61 checks passed
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
- Refactor google cloud hooks, that used generic 'wait_for_operation'
methods.

Co-authored-by: Oleg Kachur <kachur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants