Fix update issues for object and advanced-arrays fields when empty default #45313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:UI
jscheffl
added
type:bug-fix
jscheffl
force-pushed
the
bugfix/45032-fix-null-initialized-codemirrors
branch
from
485e1ea to
7a2c9d7
Compare
Closed
2 tasks
eladkal
approved these changes
Dec 31, 2024
Backport successfully created: v2-10-test
|
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
2 tasks
vikmary
added a commit
to vikmary/airflow
that referenced
this pull request
Feb 26, 2025
… fields when empty default (apache#45313) (apache#45315)" This reverts commit 200bd62.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #45032 the CodeMirror entry boxes are not working.
This is caused by how CodeMirror implements the entry: It is shadowing the original
<textarea>fields in HTML. Unfortunately only via JavaScript the content of CodeMirror and HTML is in sync....and unfortunately my hand-written JavaScript checked for NULL/empty value before getting to the fields from CodeMirror. So if an object or advanced array was initialized with an empty value, it never reached the onBlur() update action.
Moved the check for empty after the CodeMirror field check.
Alongside figured out that the same as reported for advancedArray was also happening for object, just that the object field was never correctly initialized on empty value. Fixed this as well if a field is
type=["object", "null"].closes: #45032