Fix Version Check for CLI Imports in Providers #45255
Open
+64
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugraoz93
requested review from
potiuk,
ashb,
jedcunningham and
hussein-awala
as code owners
boring-cyborg
bot
added
area:dev-tools
area:providers
provider:celery
provider:fab
labels
potiuk
approved these changes
Dec 27, 2024
|
Hmm. Interesting it was not caught by the compatibility tests |
|
And some tests still need fixing. |
Yeah, I would expect some tests to fail.
Yes, I am fixing them now. Thanks for the quick review! |
providers/src/airflow/providers/celery/executors/celery_executor.py
Outdated
Show resolved
Hide resolved
providers/src/airflow/providers/fab/auth_manager/cli_commands/db_command.py
Outdated
Show resolved
Hide resolved
bugraoz93
force-pushed
the
fix/cli-import-in-providers
branch
from
b89f1f4 to
e01cf3f
Compare
potiuk
reviewed
Dec 27, 2024
bugraoz93
force-pushed
the
fix/cli-import-in-providers
branch
from
0c8e1fe to
b2653cf
Compare
|
My local pre-commit didn't fix the exact issue even with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #44538 (comment)
While testing the changes (here #45148, I missed that we are releasing the providers from the main branch but actual versions not from the main branch. So I have only tested the changes on the main, my bad 🤦
The imports for the older versions were adjusted accordingly.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.