Fix breeze output static checks failure #45142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new click 8.1.8 makes the dictionary of options used to calculate hash of commands different for setup command. by bumping it to minimum 8.1.8 version we make the hash the same for both CI and locally installed breeze (click 8.1.8 change in pyproject.toml of breeze will force reinstallation of breeze for everyone locally).
eladkal
approved these changes
Dec 22, 2024
potiuk
deleted the
fix-static-checks-failing-with-breeze-setup-command
branch
Member
|
oh nice good to know , due to the click version difference it produced different hashes :) |
Member
Author
Yeah. We are hashing dictionaries of command information that click produces, I think the difference is that we have a option_chicken_egg_providers = click.option(
"--chicken-egg-providers",
default="",
help="List of chicken-egg provider packages - "
"those that have airflow_version >= current_version and should "
"be installed in CI from locally built packages with >= current_version.dev0 ",
envvar="CHICKEN_EGG_PROVIDERS",
)Release notes: https://github.com/pallets/click/releases/tag/8.1.8 |
Member
Author
|
Actually it is something else - because it was only setup :)... But .... It works, so no need to dig-in |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Dec 22, 2024
The new click 8.1.8 makes the dictionary of options used to calculate hash of commands different for setup command. by bumping it to minimum 8.1.8 version we make the hash the same for both CI and locally installed breeze (click 8.1.8 change in pyproject.toml of breeze will force reinstallation of breeze for everyone locally). (cherry picked from commit 4ab4707)
potiuk
added a commit
that referenced
this pull request
Dec 22, 2024
The new click 8.1.8 makes the dictionary of options used to calculate hash of commands different for setup command. by bumping it to minimum 8.1.8 version we make the hash the same for both CI and locally installed breeze (click 8.1.8 change in pyproject.toml of breeze will force reinstallation of breeze for everyone locally). (cherry picked from commit 4ab4707)
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
The new click 8.1.8 makes the dictionary of options used to calculate hash of commands different for setup command. by bumping it to minimum 8.1.8 version we make the hash the same for both CI and locally installed breeze (click 8.1.8 change in pyproject.toml of breeze will force reinstallation of breeze for everyone locally).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new click 8.1.8 makes the dictionary of options used to calculate hash of commands different for setup command. by bumping it to minimum 8.1.8 version we make the hash the same for both CI and locally installed breeze (click 8.1.8 change in pyproject.toml of breeze will force reinstallation of breeze for everyone locally).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.